Re: [PATCH 00/26] Address a couple of issues identified by Coverity

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Apr 28, 2017, 11:36 UTC
Message-ID: <alpine.DEB.2.20.1704281334060.3480@virtualbox>
In-Reply-To: <966db3c1-a2e4-1309-e178-b885d2a1108f@kdbg.org>

Hi Hannes,

On Thu, 27 Apr 2017, Johannes Sixt wrote:

Show 10 quoted lines

> Am 26.04.2017 um 22:19 schrieb Johannes Schindelin:
> > I recently registered the git-for-windows fork with Coverity to ensure
> > that even the Windows-specific patches get some static analysis love.
> >
> > While at it, I squashed a couple of obvious issues in the part that is
> > not Windows-specific.
> 
> Thanks for the fish. I'd looked at the series and had a few comments.
> 
> Hunting memory leaks is the way to insanity.

I hear you. Loud and clear.

> Never again am I going to help with this.

Awww? And here I thought I had your attention... *sniffle*

;-)

> I prefer to rewrite this codebase to C++ and have leak-free code by
> design.

I had the pleasure of working with some software developers in 2004 who were experts at introducing memory leaks into C++ code.

The same bunch of people later produced Java code that sorted a string list in cubic time (carefully avoiding java.util.Collections.sort(), of course).

For every fool-proof system invented, somebody invents a better fool.

Ciao, Dscho