Re: [PATCH] gitweb: Fix showing of path in tree view
- From
Jakub Narebski <jnareb@gmail.com>
- Date
- Sep 21, 2006, 10:19 UTC
- Message-ID
- <eetova$k32$1@sea.gmane.org>
- In-Reply-To
- <20060920231224.GN13132@pasky.or.cz>
Petr Baudis wrote:
> This patch fixes two things - links to all path elements except the last > one were broken since gitweb does not like the trailing slash in them, and > the root tree was not reachable from the subdirectory view.
Wouldn't it be better to fix git_get_hash_by_path to have it strip trailing slash? Gitweb don't like trailing slash in pathname (directory name) because while
git ls-tree $base -- dirname
shows dirname entry
git ls-tree $base -- dirname/
shows directory _contents_.
-- Jakub Narebski Warsaw, Poland ShadeHawk on #git