From: Jakub Narebski Date: Thu, 21 Sep 2006 10:19:29 GMT Subject: Re: [PATCH] gitweb: Fix showing of path in tree view Message-ID: In-Reply-To: <20060920231224.GN13132@pasky.or.cz> Petr Baudis wrote: > This patch fixes two things - links to all path elements except the last > one were broken since gitweb does not like the trailing slash in them, and > the root tree was not reachable from the subdirectory view. Wouldn't it be better to fix git_get_hash_by_path to have it strip trailing slash? Gitweb don't like trailing slash in pathname (directory name) because while git ls-tree $base -- dirname shows dirname entry git ls-tree $base -- dirname/ shows directory _contents_. -- Jakub Narebski Warsaw, Poland ShadeHawk on #git