git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] gitweb: Fix showing of path in tree view

From
Jakub Narebski <jnareb@gmail.com>
Date
Sep 20, 2006, 23:38 UTC
Message-ID
<eesje4$qku$2@sea.gmane.org>
In-Reply-To
<eesj84$qku$1@sea.gmane.org>
Jakub Narebski wrote:
Show 16 quoted lines
> Petr Baudis wrote:
> 
>> This patch fixes two things - links to all path elements except the last
>> one were broken since gitweb does not like the trailing slash in them, and
>> the root tree was not reachable from the subdirectory view.
>> 
>> To compensate for the one more slash in the front, the trailing slash is
>> not there anymore. ;-) I don't care if it stays there though.
> 
> Originally '/' was used as separator between directories making the path.
> I'd rather use ' / ' to separate parts of pathname more, and not incorporate
> it in the link.
> 
> Trailing (final) slash is present (and I think should be present) only
> for path in "tree" view. From the path alone you can see if it is "tree"
> or "blob" view.

About link to root tree: we could change the commit title to link to root tree instead of linking to commit view.

-- 
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git
Previous: Jakub NarebskiNext: Petr Baudis
Message 8 of 10 in “gitweb: Fix showing of path in tree view”
  1. gitweb: Fix showing of path in tree viewPetr Baudis, Sep 20, 2006
  2. Junio C HamanoSep 20, 2006
  3. Petr BaudisSep 20, 2006
  4. Junio C HamanoSep 20, 2006
  5. Jakub NarebskiSep 21, 2006
  6. Petr BaudisSep 21, 2006
  7. Jakub NarebskiSep 20, 2006
  8. Jakub NarebskiSep 20, 2006
  9. Petr BaudisSep 20, 2006
  10. Jakub NarebskiSep 21, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.