git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] gitweb: Fix showing of path in tree view

From
Petr Baudis <pasky@suse.cz>
Date
Sep 20, 2006, 23:12 UTC
Message-ID
<20060920231224.GN13132@pasky.or.cz>

This patch fixes two things - links to all path elements except the last one were broken since gitweb does not like the trailing slash in them, and the root tree was not reachable from the subdirectory view.

To compensate for the one more slash in the front, the trailing slash is not there anymore. ;-) I don't care if it stays there though.

Signed-off-by: Petr Baudis <pasky@suse.cz>
---
 gitweb/gitweb.perl |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 834a773..70f409e 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -1503,12 +1503,13 @@ sub git_print_page_path {
 		my $fullname = '';
 
 		print "<div class=\"page_path\">";
+		print $cgi->a({-href => href(action=>"tree", hash_base=>$hb),
+			      -title => '/'}, '/');
 		foreach my $dir (@dirname) {
-			$fullname .= $dir . '/';
+			$fullname .= ($fullname ? '/' : '') . $dir;
 			print $cgi->a({-href => href(action=>"tree", file_name=>$fullname,
 			                             hash_base=>$hb),
-			              -title => $fullname}, esc_html($dir));
-			print "/";
+			              -title => $fullname}, esc_html($dir . '/'));
 		}
 		if (defined $type && $type eq 'blob') {
 			print $cgi->a({-href => href(action=>"blob_plain", file_name=>$file_name,
@@ -1518,7 +1519,6 @@ sub git_print_page_path {
 			print $cgi->a({-href => href(action=>"tree", file_name=>$file_name,
 			                             hash_base=>$hb),
 			              -title => $name}, esc_html($basename));
-			print "/";
 		} else {
 			print esc_html($basename);
 		}
Next: Junio C Hamano
Message 1 of 10 in “gitweb: Fix showing of path in tree view”
  1. gitweb: Fix showing of path in tree viewPetr Baudis, Sep 20, 2006
  2. Junio C HamanoSep 20, 2006
  3. Petr BaudisSep 20, 2006
  4. Junio C HamanoSep 20, 2006
  5. Jakub NarebskiSep 21, 2006
  6. Petr BaudisSep 21, 2006
  7. Jakub NarebskiSep 20, 2006
  8. Jakub NarebskiSep 20, 2006
  9. Petr BaudisSep 20, 2006
  10. Jakub NarebskiSep 21, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.