Re: [PATCH] gitweb: Fix showing of path in tree view

From: Junio C Hamano <junkio@cox.net>
Date: Sep 20, 2006, 23:51 UTC
Message-ID: <7vhcz2drle.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20060920234052.GO13132@pasky.or.cz>

Petr Baudis <pasky@suse.cz> writes:

Show 14 quoted lines

>> Hmph.  I see the breakage and behaviour-wise your patch is fine.
>> 
>> But I think the older one was visually nicer and more intuitive
>> in one very small detail that I think matters.  Slashes between
>> path components were not part of the anchor elements, so it was
>> clear that there were two links in "gitweb / gitweb.perl" page
>> title, not just one link.  Now it is not obvious that clicking
>> different parts of the path string in "/stgit/commands/mail.py"
>> would lead to different places.  And as you are aware, losing
>> the leading "/" would be nicer as well ;-).
>
>   Well, this was the best I could come up without introducing "[root] /"
> or something in front of the path, which would be IMHO even uglier.
> Alternative ideas welcomed. :-)

Ok, when I commented on it I did not realize that the leading slash was clickable.

How about rendering it like this?

	/ stgit/ commands/ mail.py