git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] gitweb: Fix showing of path in tree view

From
Junio C Hamano <junkio@cox.net>
Date
Sep 20, 2006, 23:32 UTC
Message-ID
<7vpsdqdsh1.fsf@assigned-by-dhcp.cox.net>
In-Reply-To
<20060920231224.GN13132@pasky.or.cz>
Petr Baudis <pasky@suse.cz> writes:
Show 6 quoted lines
> This patch fixes two things - links to all path elements except the last
> one were broken since gitweb does not like the trailing slash in them, and
> the root tree was not reachable from the subdirectory view.
>
> To compensate for the one more slash in the front, the trailing slash is
> not there anymore. ;-) I don't care if it stays there though.
Hmph.  I see the breakage and behaviour-wise your patch is fine.

But I think the older one was visually nicer and more intuitive in one very small detail that I think matters. Slashes between path components were not part of the anchor elements, so it was clear that there were two links in "gitweb / gitweb.perl" page title, not just one link. Now it is not obvious that clicking different parts of the path string in "/stgit/commands/mail.py" would lead to different places. And as you are aware, losing the leading "/" would be nicer as well ;-).

Previous: Petr BaudisNext: Petr Baudis
Message 2 of 10 in “gitweb: Fix showing of path in tree view”
  1. gitweb: Fix showing of path in tree viewPetr Baudis, Sep 20, 2006
  2. Junio C HamanoSep 20, 2006
  3. Petr BaudisSep 20, 2006
  4. Junio C HamanoSep 20, 2006
  5. Jakub NarebskiSep 21, 2006
  6. Petr BaudisSep 21, 2006
  7. Jakub NarebskiSep 20, 2006
  8. Jakub NarebskiSep 20, 2006
  9. Petr BaudisSep 20, 2006
  10. Jakub NarebskiSep 21, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.