Re: [PATCH v2 05/11] gitweb: git_split_heads_body function.
- From
Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
- Date
- Nov 15, 2008, 12:25 UTC
- Message-ID
- <cb7bb73a0811150425j2475db8dsdee57c1cc5e208ab@mail.gmail.com>
- In-Reply-To
- <7vprkx5gqb.fsf@gitster.siamese.dyndns.org>
On Sat, Nov 15, 2008 at 1:14 PM, Junio C Hamano <gitster@pobox.com> wrote:
Show 13 quoted lines
> Jakub Narebski <jnareb@gmail.com> writes: > >> Second, this patch wouldn't do what you want from it if there are >> remotes with '/' in name. I for example use "gsoc2008/gitweb-caching" >> for Lea Wiemann repository with her GSoC 2008 work on adding caching >> to gitweb. > > I think your point is if you also use gsoc2008/gitstats from another > remote repository, these two sets of remote tracking branches will be > shown grouped together. But is it a bad thing? After all, you chose to > use hierarchical names for them, _and_ you chose to use the same toplevel > hierarchy name for them. Doesn't that mean you _wanted_ to have them both > appear in the same GSoC 2008 group?
The problem is that we have gsoc2008/gitweb-caching/branch1 gsoc2008/gitweb-caching/branch2 gsoc2008/gitstats/branch3 gsoc2008/gitstats/branch3, and my current code would show gitweb-caching/branch1, gitweb-caching/branch2 etc under gsoc2008.
Having branch1 and branch2 under gsoc2008/gitweb-caching, and branch3 and branch4 under gsoc2008/gitstats would be more logical, remote-wise, but it would of course lose the coupling between all the gsoc2008 remotes.
If deep nesting is not a problem, I can code something to have gitweb-caching and gistats under gsoc2008, and the respective branches within.
-- Giuseppe "Oblomov" Bilotta