Re: [PATCH v2 04/11] gitweb: optional custom name for refs in git_heads_body

From: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Date: Nov 15, 2008, 10:11 UTC
Message-ID: <cb7bb73a0811150211g1a48f0d1m184bbe193dea6542@mail.gmail.com>
In-Reply-To: <200811150032.14558.jnareb@gmail.com>

On Sat, Nov 15, 2008 at 12:32 AM, Jakub Narebski <jnareb@gmail.com> wrote:

Show 10 quoted lines

> On Thu, 13 Nov 2008, Giuseppe Bilotta wrote:
>
>> We make a clear separation between the hash reference and the displayed
>> name for refs displayed by git_heads_body. This can be used e.g. to
>> group them and display only the distinct part of the name.
>
> It is not clear for me from this commit message what this patch
> is meant to do. Already git_heads_body (and also git_tags_body)
> uses $ref{'name'} for display, and $ref{'fullname'} for linking
> (to avoid possibility of tag/branch name conflict).

Show 5 quoted lines

>> +             my $hname = $ref{'hname'} || $ref{'fullname'} || $ref{'name'};
>
> I don't remember setting $ref{'hname'} anywhere; if there is a patch
> that sets this, it should really be squashed together with this commit.
> Otherwise the commit is not standalone, as it should be.

The patch that sets hname is the next patch (the one that introduces git_split_heads_body. It's quite obvious that this whole 'split head lists' part needs some rethinking.

-- 
Giuseppe "Oblomov" Bilotta