Re: [PATCH v2 01/11] gitweb: introduce remote_heads feature

From: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Date: Nov 14, 2008, 21:44 UTC
Message-ID: <cb7bb73a0811141344q4360351do346def5515ec157b@mail.gmail.com>
In-Reply-To: <200811141915.17680.jnareb@gmail.com>

On Fri, Nov 14, 2008 at 7:15 PM, Jakub Narebski <jnareb@gmail.com> wrote:

Show 15 quoted lines

> On Thu, 13 Nov 2008, Giuseppe Bilotta wrote:
>
>> With this feature enabled, remotes are retrieved (and displayed)
>> when getting (and displaying) the heads list.
>
> I think it would be good idea to add in commit message idea _why_
> such feature would be useful, for example
>
>  This is useful if you want to use git-instaweb to examine the state
>  of repository, influding remote-tracking branches, or a repository
>  is fork of other repository, and remote-tracking branches are used
>  to see what commits this fork has in addition to those from forked
>  (main) repository.
>
> Or something like that.

Ah yes, many commit messages in this patchset are way too terse. A side effect of this being something like the first patchset I ever prepared. I'll rework them to something more sensible.

> It would be also in my opinion a good idea to modify git-instaweb.sh
> (I guess better in separate commit) to make it make use of this new
> feature... unless it does it already, doesn't it?

It doesn't, but it's something I have considered. I'll work on it (on a separate patch)

>> +     # Make gitweb show remotes too in the heads list
>
> I'm not native engish speaker, but shouldn't instead of "remotes too"
> be "also remotes" or "remotes also"?

No idea, I guess we'll wait for a native english speaker opinion 8-D

-- 
Giuseppe "Oblomov" Bilotta