Re: [PATCH v2 02/11] gitweb: git_get_heads_list accepts an optional list of refs.

From: Jakub Narebski <jnareb@gmail.com>
Date: Nov 14, 2008, 18:48 UTC
Message-ID: <200811141948.57785.jnareb@gmail.com>
In-Reply-To: <1226616555-24503-3-git-send-email-giuseppe.bilotta@gmail.com>

Dnia czwartek 13. listopada 2008 23:49, Giuseppe Bilotta napisał:

> git_get_heads_list(limit, dir1, dir2, ...) can now be used to retrieve
> refs/dir1, refs/dir2 etc. Defaults to ('heads') or ('heads', 'remotes')
> depending on the remote_heads option.

Minor nit: I think it would be better to use the same terminology in commit message as in code, i.e. 'class1' instead of 'dir1', or perhaps 'ref_class1' if it would be better.

This is only a suggestion, but perhaps this patch could be squashed with a later one?

Show 21 quoted lines

> 
> Signed-off-by: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
> ---
>  gitweb/gitweb.perl |   11 +++++++----
>  1 files changed, 7 insertions(+), 4 deletions(-)
> 
> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
> index b6c4233..d7c97a3 100755
> --- a/gitweb/gitweb.perl
> +++ b/gitweb/gitweb.perl
> @@ -2663,15 +2663,18 @@ sub parse_from_to_diffinfo {
>  ## parse to array of hashes functions
>  
>  sub git_get_heads_list {
> -	my $limit = shift;
> +	my ($limit, @class) = @_;
> +	unless (defined @class) {
> +		my ($remote_heads) = gitweb_check_feature('remote_heads');
> +		@class = ('heads', $remote_heads ? 'remotes' : undef);
> +	}
> +	my @refs = map { "refs/$_" } @class;

Nice.

Show 12 quoted lines

>  	my @headslist;
>  
> -	my ($remote_heads) = gitweb_check_feature('remote_heads');
> -
>  	open my $fd, '-|', git_cmd(), 'for-each-ref',
>  		($limit ? '--count='.($limit+1) : ()), '--sort=-committerdate',
>  		'--format=%(objectname) %(refname) %(subject)%00%(committer)',
> -		'refs/heads', ( $remote_heads ? 'refs/remotes' : '')
> +		@refs
>  		or return;
>  	while (my $line = <$fd>) {
>  		my %ref_item;

So this is a bit of generalization of (part of) previous patch, isn't it?

-- 
Jakub Narebski
Poland