Re: [PATCH] gitweb: ref markers link to named shortlogs

From: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Date: Aug 28, 2008, 06:26 UTC
Message-ID: <cb7bb73a0808272326s77391a10v607043f82f9b581f@mail.gmail.com>
In-Reply-To: <48B602B5.1070304@gmail.com>

On Thu, Aug 28, 2008 at 3:43 AM, Lea Wiemann <lewiemann@gmail.com> wrote:

Show 7 quoted lines

> Jakub Narebski wrote:
>> By the way, this is argument *for* selecting action when generating
>> link, if it is possible without incurring unnecessary (if you don't
>> follow the link) performance penalty.
>
> I agree that it's much cleaner to select the action when generating the
> page, rather than having an 'objectview' action or so.

In that case v7 of my patch is The Way (TM).

Show 6 quoted lines

> Worrying about performance seems like premature optimization though --
> my guesstimate is that the performance penalty for looking up the object
> type is not practically noticeable (read: relevant), and with my patch
> applied (even without caching activated) it should move below the
> measurable range.  So don't complicate the code to gain another 0.01%
> performance. ;-)

Well, considering that after Jakub's suggestion we just get the target type from the presence and absence of ^{} in the output of show-refs, we're not making the code overly complex :)

BTW, any ETA on your caching changes landing in git? I'm really curious to see how many of my changes are not compatible with it 8-D

-- 
Giuseppe "Oblomov" Bilotta