Re: [PATCH v5] gitweb: ref markers link to named shortlogs

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 25, 2008, 04:11 UTC
Message-ID: <7vvdxpivig.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <200808250444.23305.jnareb@gmail.com>

Jakub Narebski <jnareb@gmail.com> writes:

Show 6 quoted lines

> +                     $markers .= " <span class=\"$class\" title=\"$ref\">" .
> +                             $cgi->a({-href => href(action=>( $indirect ? "tag" : "shortlog"),
> +                                                    hash=>"refs/$ref")}, $name) .
> +                             "</span>";
>
> or equivalent (not stripping "refs/" in git_get_references).

If you mean by "hash => $it", I think it is only used as the URL the anchor points at, and it is much more preferable to use the canonical form. "...?h=refs/heads/master" and "...h=heads/master" might produce the same output, but then it is better for smart caching layer if you always used canonical form, isn't it?