git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v4] gitweb: ref markers link to named shortlogs

From
Jakub Narebski <jnareb@gmail.com>
Date
Aug 22, 2008, 13:42 UTC
Message-ID
<200808221542.13227.jnareb@gmail.com>
In-Reply-To
<cb7bb73a0808220620m10245693pabe49993e91cff3d@mail.gmail.com>
Giuseppe Bilotta wrote:
Show 12 quoted lines
> On Fri, Aug 22, 2008 at 3:01 PM, Jakub Narebski <jnareb@gmail.com> wrote:
> >
> > Seems overly complicated.  How about something like this, instead?
> > It simply moves stripping ^{} from refs to format_ref_marker(),
> > and uses "tags/v1.5.0^{}" instead of [ "tags/v1.5.0", 1 ].
> 
> My thought was that if the refs stuff was being used for something
> else than format_ref_marker, it would fail more spectacularly due to
> the different kind of values, rather than introducing potentially
> subtle bugs due to the additiona ^{} popping in unexpectedly, but it
> wouldn't be a problem to do it the simple way. Let me clean the patch
> up and resubmit it.

This might be good idea, but for the two following reasons: a) it makes code more complicated, b) it is inconsistent, because ref type would be saved in refname then stripped in format_ref_marker, while indirection would be saved in git_get_references; consistent would be ["tags", "v1.5.0", 1].

Thanks for your work on improving gitweb.
-- 
Jakub Narebski
Poland
Previous: Giuseppe BilottaNext: Giuseppe Bilotta
Message 23 of 33 in “gitweb: ref markers link to named shortlogs”
  1. gitweb: ref markers link to named shortlogsGiuseppe Bilotta, Aug 21, 2008
  2. Jakub NarebskiAug 21, 2008
  3. Giuseppe BilottaAug 22, 2008
  4. Jakub NarebskiAug 22, 2008
  5. [PATCHv3] gitweb: ref markers link to named shortlogsGiuseppe Bilotta, Aug 22, 2008
  6. Lea WiemannAug 24, 2008
  7. Giuseppe BilottaAug 24, 2008
  8. Jakub NarebskiAug 24, 2008
  9. Giuseppe BilottaAug 25, 2008
  10. Jakub NarebskiAug 26, 2008
  11. Giuseppe BilottaAug 26, 2008
  12. Jakub NarebskiAug 26, 2008
  13. Giuseppe BilottaAug 26, 2008
  14. Giuseppe BilottaAug 27, 2008
  15. Lea WiemannAug 28, 2008
  16. Giuseppe BilottaAug 28, 2008
  17. Jakub NarebskiAug 28, 2008
  18. Jakub NarebskiAug 22, 2008
  19. Giuseppe BilottaAug 22, 2008
  20. gitweb: ref markers link to named shortlogsGiuseppe Bilotta, Aug 22, 2008
  21. Jakub NarebskiAug 22, 2008
  22. Giuseppe BilottaAug 22, 2008
  23. Jakub NarebskiAug 22, 2008
  24. Giuseppe BilottaAug 22, 2008
  25. gitweb: ref markers link to named shortlogsGiuseppe Bilotta, Aug 22, 2008
  26. Jakub NarebskiAug 24, 2008
  27. Miklos VajnaAug 25, 2008
  28. Jakub NarebskiAug 25, 2008
  29. Junio C HamanoAug 25, 2008
  30. Jakub NarebskiAug 25, 2008
  31. Junio C HamanoAug 25, 2008
  32. gitweb: ref markers link to named shortlogsGiuseppe Bilotta, Aug 26, 2008
  33. gitweb: ref markers link to named shortlogsGiuseppe Bilotta, Aug 26, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.