Re: [PATCH] gitweb: ref markers link to named shortlogs

From: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Date: Aug 26, 2008, 10:58 UTC
Message-ID: <cb7bb73a0808260358o41a04a9ara701e6c726cf2298@mail.gmail.com>
In-Reply-To: <200808261015.37023.jnareb@gmail.com>

On Tue, Aug 26, 2008 at 10:15 AM, Jakub Narebski <jnareb@gmail.com> wrote:

Show 5 quoted lines

> BTW. one thing that can be done is consolidation of "guessing action"
> code: it is done by simply calculating what is to put in $action during
> dispatch, or is done in 'object' view to calculate redirect URL with
> proper action.  I have tried to bring them together, but patches were
> I think lost in the noise.

Ah, but the problem is that guessing the action based on the object sometimes depends on the context: for some cases the 'commit' action is the correct one for commits, in other cases shortlog is preferred. This is why I introduced the %views hash in some of my patches.

> IMHO v5 with small change making refs canonical (hash=>"refs/$ref")
> is preferred way to do this.  You can send v6 patch or I can send
> it (I planned doing this today).

I can do it, no problem.

Show 6 quoted lines

> First, the great problem with gitweb patches as of today is if Lea
> Google Summer of Code 2008 work on gitweb caching would be accepted
> (merged in) into git repository; I pretty much think that any gitweb
> improvements would be "incompatibile" (read: causing conflicts) with
> 'gitweb caching' patch covering such large parts of code... but
> I might be mistaken about that.

That's ok, I can wait for Lea's code to get into the repo, so I can work on the conflicts myself. I'm not sure what parts of the code she touches though, so for some things it might be easy (the pathinfo stuff, for example). Other features such as my allheads thing would probably need to be reworked for caching.

> Thank you for contributing to gitweb...

My pleasure.

-- 
Giuseppe "Oblomov" Bilotta