Re: [PATCH] gitweb: ref markers link to named shortlogs

From: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Date: Aug 22, 2008, 12:34 UTC
Message-ID: <cb7bb73a0808220534i2786af30hc924e9965cdb7fa8@mail.gmail.com>
In-Reply-To: <200808221256.21805.jnareb@gmail.com>

On Fri, Aug 22, 2008 at 12:56 PM, Jakub Narebski <jnareb@gmail.com> wrote:

Show 14 quoted lines

> This "couple of extra info" could be just '^{}' suffix.  So I don't
> think it would be very complicated.
>
> You could simply do not strip '^{}' suffix in git_get_references()
> subroutine (so for example $refs->{$id} could be "tags/v1.6.0^{}",
> and not simply "tags/v1.6.0" when $id is sha-1 of a _commit_ indirectly
> referenced by v1.6.0, i.e. referenced by v1.6.0 _tag_), and strip
> it and make use of it in format_ref_marker():
>
>   if ($ref =~ s/\^\{\}$//) {
>      # $ref is a tag
>   } else {
>      # $ref points directly to object
>   }

I've actually changed the format of $refs, making the values into arrays whose first value is the name and the other is the ^{} marker, if present. Patch incoming.

> P.S. I have re-added git mailing list to Cc:.

Oops, didn't realized I had forgotten it.

-- 
Giuseppe "Oblomov" Bilotta