Re: [PATCH] gitweb: ref markers link to named shortlogs
- From
Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
- Date
- Aug 24, 2008, 19:41 UTC
- Message-ID
- <cb7bb73a0808241241q19af5fai708935c29373042d@mail.gmail.com>
- In-Reply-To
- <48B1B6F2.5050301@gmail.com>
On Sun, Aug 24, 2008 at 9:30 PM, Lea Wiemann <lewiemann@gmail.com> wrote:
Show 11 quoted lines
> Giuseppe Bilotta wrote:
>> + my $git_type = git_get_type($ref);
>> [...]
>> + $cgi->a({-href => href(action=>$view{$git_type} || $git_type, hash=>$name)}, $name) .
>
> Since some of this thread seems to be about performance, you might just
> make this a link to action => 'object' (and save the git_get_type call)
> and let gitweb Do The Right Thing when the link is followed.
>
> [Disclaimer: Haven't read the whole thread, and haven't checked if
> action=object is actually doing the right thing here.]The object would do the right thing if we wanted 'commit' to be the default action for commits, but we actually want shortlogs in that case.
However, this remark of yours makes me think of a different way to approach the problem: create an 'objectview' action that acts just like object, but actually maps those objects to an appropriate default view. I'd like to hear Petr's and Jakub's opinion, and if they think it's a better approach than the latest version of my patch http://marc.info/?l=git&m=121941177812828&w=2 (which has not received any comments yet), I'll implemented it that way.
-- Giuseppe "Oblomov" Bilotta