Re: [RFC PATCH v3 00/15] Modernize the build system

From: Ramsay Jones <ramsay@ramsayjones.plus.com>
Date: Oct 23, 2024, 14:38 UTC
Message-ID: <c32a7dc3-cf9f-4d42-98da-80009f9df847@ramsayjones.plus.com>
In-Reply-To: <ZxjmTbATU7usHcqQ@pks.im>

On 23/10/2024 13:04, Patrick Steinhardt wrote:

> On Mon, Oct 21, 2024 at 11:56:42PM +0100, Ramsay Jones wrote:
>> On 20/10/2024 09:51, Eli Schwartz wrote:
>>> On 10/18/24 12:08 PM, Ramsay Jones wrote:
>> [snip]

Show 15 quoted lines

>> Patrick, how do you run the tests on cygwin?
> 
> I didn't have to do anything special here, so this is quite puzzling. In
> a fully-updated Cygwin installation:
> 
>     $ which meson
>     /usr/bin/meson
>     $ meson --version
>     1.3.2
>     $ python --version
>     3.9.16
>     $ mkdir build
>     $ meson setup ..
>     ... autoconfiguration logs ...
>     $ meson test 't000*'

Hmm, I could have sworn that this caused a complete rebuild for me (even when having just built), hence the '--no-rebuild --print-errorlogs' parameters to meson test. (Oh, maybe that was just 'meson test' - so how do you run *all* tests with meson - rather than 'ninja test').

Show 23 quoted lines

>     ninja: Entering directory `/home/Patrick Steinhardt/git/build'
>     [582/582] Linking target git-receive-pack.exe
>     1/9 t0005-signals           OK              4.17s
>     2/9 t0004-unwritable        OK              4.58s
>     3/9 t0002-gitfile           OK              6.95s
>     4/9 t0007-git-var           OK              8.15s
>     5/9 t0006-date              OK             15.42s
>     6/9 t0003-attributes        OK             26.84s
>     7/9 t0001-init              OK             29.09s
>     8/9 t0008-ignores           OK             57.17s
>     9/9 t0000-basic             OK             83.82s
> 
>     Ok:                 9
>     Expected Fail:      0
>     Fail:               0
>     Unexpected Pass:    0
>     Skipped:            0
>     Timeout:            0
> 
>     Full log written to /home/Patrick Steinhardt/git/build/meson-logs/testlog.txt
> 
> This is starting with a fresh repo, I executed `git clean -dfx`
> beforehand.

Hmm, I have far to many 'precious' files to use 'git clean'! (perhaps I should clone the repo to get a totally clean slate).

> 
> Do any of the versions used maybe differ?

Ah, yes, I should have noted the versions:

  $ uname -a
  CYGWIN_NT-10.0-19045 satellite 3.5.4-1.x86_64 2024-08-25 16:52 UTC x86_64 Cygwin
  $

  $ which meson ninja python
  /usr/bin/meson
  /usr/bin/ninja
  /usr/bin/python
  $

  $ meson --version
  1.3.2
  $

  $ ninja --version
  1.12.0
  $

  $ python --version
  Python 3.9.18
  $

So, a slightly newer python - what versions of ninja and the cygwin '.dll' are you using? (the latter is more likely to cause an issue).

BTW, I have been doing:

  $ meson setup .. -Dprefix=$HOME

so that it matches the default prefix from the Makefile (not that I have attempted to actually install yet!;) ). Can the default be set in the meson.build file (with command-line override, of course)?

ATB, Ramsay Jones