Re: [RFC PATCH v3 00/15] Modernize the build system

From: Ramsay Jones <ramsay@ramsayjones.plus.com>
Date: Oct 25, 2024, 16:36 UTC
Message-ID: <48a506c1-67a8-4ac1-9a2c-392125bb0944@ramsayjones.plus.com>
In-Reply-To: <Zxsqr3X4FAWfy0HP@pks.im>

On 25/10/2024 06:20, Patrick Steinhardt wrote:

Show 11 quoted lines

> On Thu, Oct 24, 2024 at 06:34:24PM +0100, Ramsay Jones wrote:
>> On 24/10/2024 08:19, Patrick Steinhardt wrote:
>> Having a quick squint at the failure, it '# failed 1 among 397 test(s)'
>> which was 'not ok 391 - correct handling of backslashes', which is the
>> only test marked with a '!CYGWIN' prerequisite! ;) So it seems that I
>> am doing something wrong, which results in the prerequisite not being
>> set.
> 
> The CYGWIN prerequisite is set depending on whether or not `uname -s`
> contains "*CYGWIN*". Does your system maybe pick up the wrong uname(1)
> binary somehow?

Yep, I suspected that I knew what the problem was, I just had not looked to see if my hunch was correct yet! :) And indeed:

  $ pwd
  /home/ramsay/git
  $ ls -l uname*
  -rw-r--r-- 1 ramsay None  11K Jun 28  2019 uname.c
  -rwxr-xr-x 1 ramsay None 167K Jun 28  2019 uname.exe*
  $ ./uname -s
  Windows
  $ ./uname -a
  Windows satellite 10.0 19045() AMD-64 Windows 10 Home
  $ uname -a
  CYGWIN_NT-10.0-19045 satellite 3.5.4-1.x86_64 2024-08-25 16:52 UTC x86_64 Cygwin
  $

As you can see, many many moons ago (28 Jun 2019 was just the last time it was updated/built - I suspect it was first written in 2006), I had written my own version of uname. If memory serves, it was actually for the 'msys' version, not cygwin! ;)

Anyway, when the test executes my PATH starts:

    /home/ramsay/git/build/bin-wrappers:/home/ramsay/git:/usr/bin ...

It is not immediately obvious why '/home/ramsay/git' is in there, but if I move my uname out of the way:

  $ mv uname* ../src
  $ ls -l uname*
  ls: cannot access 'uname*': No such file or directory
  $

then everything works:

  $ cd build
  $ meson test 't000*'
  ninja: Entering directory `/home/ramsay/git/build'
  ninja: no work to do.
  1/9 t0002-gitfile           OK             10.28s
  2/9 t0004-unwritable        OK              6.70s
  3/9 t0005-signals           OK              6.13s
  4/9 t0003-attributes        OK             52.56s
  5/9 t0006-date              OK             30.16s
  6/9 t0001-init              OK             60.24s
  7/9 t0007-git-var           OK             12.93s
  8/9 t0008-ignores           OK             106.42s
  9/9 t0000-basic             OK             192.99s
  
  Ok:                 9
  Expected Fail:      0
  Fail:               0
  Unexpected Pass:    0
  Skipped:            0
  Timeout:            0
  
  Full log written to /home/ramsay/git/build/meson-logs/testlog.txt
  $

So, I just need to build the v4 version and test again (at some point I have to do a full (6 hour+) test run on cygwin!).

Thanks!

ATB, Ramsay Jones