Re: [RFC PATCH 04/21] t/lib-gpg: fix setup of GNUPGHOME in MinGW

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Oct 2, 2024, 21:49 UTC
Message-ID: <CAPig+cRNPmbAY=HAkxnioXeq=gDSaYQzytE8Yj0DLanYMT7rxQ@mail.gmail.com>
In-Reply-To: <b5c116396da61f44057fbb5a8abcefe7ab1b67f4.1727881164.git.ps@pks.im>

On Wed, Oct 2, 2024 at 11:17 AM Patrick Steinhardt <ps@pks.im> wrote:

> In "t/lib-gpg.sh" we set up the "GNUPGHOME" environment variable to
> point to a test-specific diretcory. This is done by using "$PWD/gpghome"

s/diretcory/directory/

Show 5 quoted lines

> as value, where "$PWD" is the current test's trash directory.
>
> This is broken for MinGW though because "$PWD" will use Windows-style
> paths that contain drive letters. What we really want in this context is
> a Unix-style path, which we can get by using `$(pwd)` instead.

It's not clear from this description why Windows- vs. Unix-style paths only now become a problem but have not been a problem up to this point. Is it because PGP testing has always been disabled on Windows until now? Or some other reason?

> Adapt the code accordingly to fix tests using this library.
>
> Signed-off-by: Patrick Steinhardt <ps@pks.im>