Re: [RFC PATCH 04/21] t/lib-gpg: fix setup of GNUPGHOME in MinGW

From: Patrick Steinhardt <ps@pks.im>
Date: Oct 7, 2024, 10:18 UTC
Message-ID: <ZwO1X1V1R9Eoy7_L@pks.im>
In-Reply-To: <CAPig+cRNPmbAY=HAkxnioXeq=gDSaYQzytE8Yj0DLanYMT7rxQ@mail.gmail.com>

On Wed, Oct 02, 2024 at 05:49:10PM -0400, Eric Sunshine wrote:

Show 5 quoted lines

> On Wed, Oct 2, 2024 at 11:17 AM Patrick Steinhardt <ps@pks.im> wrote:
> > In "t/lib-gpg.sh" we set up the "GNUPGHOME" environment variable to
> > point to a test-specific diretcory. This is done by using "$PWD/gpghome"
> 
> s/diretcory/directory/

Thanks, fixed.

Show 10 quoted lines

> > as value, where "$PWD" is the current test's trash directory.
> >
> > This is broken for MinGW though because "$PWD" will use Windows-style
> > paths that contain drive letters. What we really want in this context is
> > a Unix-style path, which we can get by using `$(pwd)` instead.
> 
> It's not clear from this description why Windows- vs. Unix-style paths
> only now become a problem but have not been a problem up to this
> point. Is it because PGP testing has always been disabled on Windows
> until now? Or some other reason?

I guess that nobody ever ran these tests on Windows with GnuPG installed. It is installed in MinGW though because pacman pulls it in as a dependency.

Anyway, I've amended the commit message accordingly.

Patrick

> > Adapt the code accordingly to fix tests using this library.
> >
> > Signed-off-by: Patrick Steinhardt <ps@pks.im>