Re: [RFC PATCH 15/21] Makefile: consistently use @PLACEHOLDER@ to substitute

From: Patrick Steinhardt <ps@pks.im>
Date: Oct 8, 2024, 14:23 UTC
Message-ID: <ZwVAXNGTQhUNvBXL@pks.im>
In-Reply-To: <87ab47ef-8ac8-4e4c-9a1e-f5f630f1d21e@gmail.com>

On Tue, Oct 08, 2024 at 03:04:29PM +0100, Phillip Wood wrote:

Show 13 quoted lines

> Hi Patrick
> 
> On 02/10/2024 16:16, Patrick Steinhardt wrote:
> > We have a bunch of placeholders in our scripts that we replace at build
> > time, for example by using sed(1). These placeholders come in three
> > different formats: @PLACEHOLDER@, @@PLACEHOLDER@@ and ++PLACEHOLDER++.
> 
> I agree that it's a good idea to stanardise on a single format here.
> 
> > Next to being inconsistent it also creates a bit of a problem with
> > CMake, which only supports the first syntax.
> 
> I'm a bit confused - is this referring to CMake's "configure_file" command?

Ah, yes. I should've made this more explicit.

Patrick

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.