Re: [RFC PATCH v4 00/19] Modernize the build system
- From
Jeff King <peff@peff.net>
- Date
- Nov 11, 2024, 22:13 UTC
- Message-ID
- <20241111221320.GF5019@coredump.intra.peff.net>
- In-Reply-To
- <bfc876ea-1a90-4e78-8756-efdcd53e7525@gentoo.org>
On Mon, Nov 11, 2024 at 04:39:08PM -0500, Eli Schwartz wrote:
Show 24 quoted lines
> > I hadn't tried it. I did now, checking out origin/ps/build^ (to drop the > > "seen" resolution topic), but it didn't work: > > > > $ meson setup build > > [...] > > Program msgfmt found: NO > > po/meson.build:3: WARNING: Gettext not found, all translation (po) targets will be ignored. > > > > po/meson.build:3:20: ERROR: Can not assign void to variable. > > > > I guess the assignment of "translations" there needs to be made > > conditional? > > > Yeah, this is an interesting quirk. Many projects would tend to figure > that translation (po) targets are "optional" because if you don't have > msgfmt installed then you can just install the project without any > translations and then non-English speakers will be inconvenienced but at > least the entire project isn't completely un-buildable. So meson > automatically disables the target and logs a warning, but then this > project *also* wants to depend on the translations for the testsuite. > > So this should be taken into account. Do the tests actually need > translations, though?
No, they don't. I don't have msgfmt on my system at all, and always build with NO_GETTEXT.
-Peff