Re: [PATCH] gitweb: Better regexp for SHA-1 committag match
- From
- Rafael Garcia-Suarez <rgarciasuarez@gmail.com>
- Date
- Feb 6, 2009, 09:49 UTC
- Message-ID
- <b77c1dce0902060149j25e76250q76c2368bd3ca5857@mail.gmail.com>
- In-Reply-To
- <200902061012.42943.jnareb@gmail.com>
2009/2/6 Jakub Narebski <jnareb@gmail.com>:
Show 5 quoted lines
> Make SHA-1 regexp to be turned into hyperlink (the SHA-1 committag) > to match word boundary at the beginning and the end. This way we > reduce number of false matches, for example we now don't match > 0x74a5cd01 which is hex decimal (for example memory address), > but is not SHA-1.
Further suggestion: you could also turn the final \b into (\b|\@), so it skips stuff that might look like a message-id. Here's an example : http://perl5.git.perl.org/perl.git/commit/f57255841c18e91c7a719a2400645e39398f3947 (We get loads of this in the Perl repository)
Show 27 quoted lines
> Suggested-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
> Signed-off-by: Jakub Narebski <jnareb@gmail.com>
> ---
> gitweb/gitweb.perl | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
> index f27dbb6..bec1af6 100755
> --- a/gitweb/gitweb.perl
> +++ b/gitweb/gitweb.perl
> @@ -1364,7 +1364,7 @@ sub format_log_line_html {
> my $line = shift;
>
> $line = esc_html($line, -nbsp=>1);
> - if ($line =~ m/([0-9a-fA-F]{8,40})/) {
> + if ($line =~ m/\b([0-9a-fA-F]{8,40})\b/) {
> my $hash_text = $1;
> my $link =
> $cgi->a({-href => href(action=>"object", hash=>$hash_text),
> --
> 1.6.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>-- "You don't mean odds and ends, you mean des curieux et des bouts", corrected the manager. -- Terry Pratchett, Hogfather