git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCHv2] gitweb: Better regexp for SHA-1 committag match

From
Jakub Narebski <jnareb@gmail.com>
Date
Feb 7, 2009, 09:25 UTC
Message-ID
<200902071025.02491.jnareb@gmail.com>
In-Reply-To
<7v7i42y6ms.fsf@gitster.siamese.dyndns.org>
Junio C Hamano wrote:
Show 13 quoted lines
> Jakub Narebski <jnareb@gmail.com> writes:
> 
> > It would unfortunately falsely match... but we cannot eliminate this
> > case (well, at least not checking if hexnumber is followed by dot),
> > because of totally legitimate
> >
> >    ... at commit 8457bb9e.
> >
> > So even with that we would have still false matches...
> 
> Yeah, so what's the value in v2 over v1?  It is still wrong but it is less
> wrong than it used to be?  I think the word-boundary one made a good
> sense.  I do not see the @lookahead adding much value at all.

Right. So v2 is less useful that I thought it to be; and adding further "exceptions" doesn't seem like a good idea. The 'msgid' committag when/if it gets implemented would help there...

So please take v1, as it is sane improvement and generic enough.
-- 
Jakub Narebski
Poland
Previous: Junio C HamanoNext: demerphq
Message 16 of 22 in “webgit highlightes mem adresses as git versions”
  1. Toralf FörsterFeb 2, 2009
  2. Jakub NarebskiFeb 2, 2009
  3. Toralf FörsterFeb 3, 2009
  4. Johannes SchindelinFeb 3, 2009
  5. gitweb: Better regexp for SHA-1 committag matchJakub Narebski, Feb 6, 2009
  6. Rafael Garcia-SuarezFeb 6, 2009
  7. Jakub NarebskiFeb 6, 2009
  8. Rafael Garcia-SuarezFeb 6, 2009
  9. [PATCHv2] gitweb: Better regexp for SHA-1 committag matchJakub Narebski, Feb 6, 2009
  10. Johannes SchindelinFeb 6, 2009
  11. Jay SoffianFeb 6, 2009
  12. Jakub NarebskiFeb 6, 2009
  13. Junio C HamanoFeb 7, 2009
  14. Jakub NarebskiFeb 7, 2009
  15. Junio C HamanoFeb 7, 2009
  16. Jakub NarebskiFeb 7, 2009
  17. demerphqFeb 7, 2009
  18. Jakub NarebskiFeb 7, 2009
  19. Jakub NarebskiFeb 7, 2009
  20. demerphqFeb 7, 2009
  21. Jakub NarebskiFeb 7, 2009
  22. demerphqFeb 7, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.