Re: webgit highlightes mem adresses as git versions
At Monday 02 February 2009 23:54:20 Jakub Narebski wrote :
Show 10 quoted lines
> Toralf Förster <toralf.foerster@gmx.de> writes:
> > As seen here
> > http://git.kernel.org/?p=linux/kernel/git/stable/linux-2.6.27.y.git;a=com
> >mit;h=8ca2918f99b5861359de1805f27b08023c82abd2 the strings [<c043d0f3>]
> > and firends shouldn't be recognized as git hashes, isn't it ?
>
> Gitweb, not webgit. And gitweb considers ([0-9a-fA-F]{8,40}) i.e.
> from 8 to 40 hexadecimal characters to be (shortened) SHA-1. It
> simply cannot afford checking if such object exists when displaying
> commit message (for example in 'log' view).Ah - ok, what's about expecting spaces around such SHA-1 keys ?
--
MfG/Sincerely
Toralf Förster
pgp finger print: 7B1A 07F4 EC82 0F90 D4C2 8936 872A E508 7DB6 9DA3