Re: [PATCH] gitweb: Better regexp for SHA-1 committag match

From: Jakub Narebski <jnareb@gmail.com>
Date: Feb 6, 2009, 10:26 UTC
Message-ID: <200902061126.18418.jnareb@gmail.com>
In-Reply-To: <b77c1dce0902060149j25e76250q76c2368bd3ca5857@mail.gmail.com>

Dnia piątek 6. lutego 2009 10:49, Rafael Garcia-Suarez napisał:

> 2009/2/6 Jakub Narebski <jnareb@gmail.com>:

Show 7 quoted lines

> > Make SHA-1 regexp to be turned into hyperlink (the SHA-1 committag)
> > to match word boundary at the beginning and the end.  This way we
> > reduce number of false matches, for example we now don't match
> > 0x74a5cd01 which is hex decimal (for example memory address),
> > but is not SHA-1.
> 
> Further suggestion: you could also turn the final \b into (\b|\@),

You meant \b -> \b(?!\@), didn't you? Word boundary _not_ followed by '@', and not word boundary _OR_ '@' as you wrote...

> so it skips stuff that might look like a message-id.
> Here's an example :
> http://perl5.git.perl.org/perl.git/commit/f57255841c18e91c7a719a2400645e39398f3947

For those who do not want to open browser, it is:

Message-ID: <46A0F33545E63740BC7563DE59CA9C6D0939A0@exchsvr2.npl.ad.local>

> (We get loads of this in the Perl repository)

> > -       if ($line =~ m/([0-9a-fA-F]{8,40})/) {
> > +       if ($line =~ m/\b([0-9a-fA-F]{8,40})\b/) {

-- 
Jakub Narebski
Poland