git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] gitweb: Better regexp for SHA-1 committag match

From
Ddemerphq <demerphq@gmail.com>
Date
Feb 7, 2009, 09:22 UTC
Message-ID
<9b18b3110902070122r3397888aqcaebfcf3e6d40d51@mail.gmail.com>
In-Reply-To
<200902061126.18418.jnareb@gmail.com>
2009/2/6 Jakub Narebski <jnareb@gmail.com>:
Show 13 quoted lines
> Dnia piątek 6. lutego 2009 10:49, Rafael Garcia-Suarez napisał:
>> 2009/2/6 Jakub Narebski <jnareb@gmail.com>:
>
>> > Make SHA-1 regexp to be turned into hyperlink (the SHA-1 committag)
>> > to match word boundary at the beginning and the end.  This way we
>> > reduce number of false matches, for example we now don't match
>> > 0x74a5cd01 which is hex decimal (for example memory address),
>> > but is not SHA-1.
>>
>> Further suggestion: you could also turn the final \b into (\b|\@),
>
> You meant \b -> \b(?!\@), didn't you?  Word boundary _not_ followed
> by '@', and not word boundary _OR_ '@' as you wrote...

Since \b(?!\@) is effectively two zero width negative assertions in a row you could simplify by saying:

  (?![^\w\@])
and that way you can easily add the '.' case as well.
Yves
-- 
perl -Mre=debug -e "/just|another|perl|hacker/"
Previous: Jakub NarebskiNext: Jakub Narebski
Message 20 of 22 in “webgit highlightes mem adresses as git versions”
  1. Toralf FörsterFeb 2, 2009
  2. Jakub NarebskiFeb 2, 2009
  3. Toralf FörsterFeb 3, 2009
  4. Johannes SchindelinFeb 3, 2009
  5. gitweb: Better regexp for SHA-1 committag matchJakub Narebski, Feb 6, 2009
  6. Rafael Garcia-SuarezFeb 6, 2009
  7. Jakub NarebskiFeb 6, 2009
  8. Rafael Garcia-SuarezFeb 6, 2009
  9. [PATCHv2] gitweb: Better regexp for SHA-1 committag matchJakub Narebski, Feb 6, 2009
  10. Johannes SchindelinFeb 6, 2009
  11. Jay SoffianFeb 6, 2009
  12. Jakub NarebskiFeb 6, 2009
  13. Junio C HamanoFeb 7, 2009
  14. Jakub NarebskiFeb 7, 2009
  15. Junio C HamanoFeb 7, 2009
  16. Jakub NarebskiFeb 7, 2009
  17. demerphqFeb 7, 2009
  18. Jakub NarebskiFeb 7, 2009
  19. Jakub NarebskiFeb 7, 2009
  20. demerphqFeb 7, 2009
  21. Jakub NarebskiFeb 7, 2009
  22. demerphqFeb 7, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.