Re: [PATCHv2] gitweb: Better regexp for SHA-1 committag match

From: Jakub Narebski <jnareb@gmail.com>
Date: Feb 6, 2009, 22:00 UTC
Message-ID: <200902062300.16798.jnareb@gmail.com>
In-Reply-To: <76718490902061347h5bc35e7et9e1b66bf9dd2c93a@mail.gmail.com>

Jay Soffian wrote:

Show 18 quoted lines

> On Fri, Feb 6, 2009 at 8:03 AM, Johannes Schindelin
> <Johannes.Schindelin@gmx.de> wrote:
>> On Fri, 6 Feb 2009, Jakub Narebski wrote:
>>
>>> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
>>> index f27dbb6..5dcc108 100755
>>> --- a/gitweb/gitweb.perl
>>> +++ b/gitweb/gitweb.perl
>>> @@ -1364,7 +1364,7 @@ sub format_log_line_html {
>>>       my $line = shift;
>>>
>>>       $line = esc_html($line, -nbsp=>1);
>>> -     if ($line =~ m/([0-9a-fA-F]{8,40})/) {
>>> +     if ($line =~ m/\b([0-9a-fA-F]{8,40})\b(!?\@)/) {
>>
>> Looks good to me!
> 
> I wonder if just matching lower-case a-f would be sufficient as well?

Well...

On one hand side git generates always lower-case a-f for SHA-1. On the other hand git _accepts_ upper-case A-F for SHA-1 of object.

-- 
Jakub Narebski
Poland