From: Derrick Stolee Date: Fri, 05 Feb 2021 11:42:24 GMT Subject: Re: [PATCH v2 09/17] midx: return success/failure in chunk write methods Message-ID: In-Reply-To: On 2/4/2021 5:59 PM, Junio C Hamano wrote: > "Derrick Stolee via GitGitGadget" writes: > In this step I see the same "f->total + f->offset" sprinkled in some > places, but they will all go away in the "midx: use chunk-format API > in write_midx_internal()" step, so it is not such a huge deal. I'll move the ones that are introduced by this patch, but others already exist that also get removed by a later patch. I won't touch those until they are deleted. Thanks, -Stolee