git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 5/6] odb/transaction: avoid "ODB" in error messages

From
Patrick Steinhardt <ps@pks.im>
Date
Nov 19, 2026, 12:15 UTC
Message-ID
<av7oWMU84sH-Wx1c@pks.im>
In-Reply-To
<20261119002043.2108654-6-jltobler@gmail.com>
On Wed, Nov 18, 2026 at 06:20:42PM -0600, Justin Tobler wrote:
Show 23 quoted lines
> diff --git a/odb/transaction.h b/odb/transaction.h
> index 2a40c85bc8..f6c4b523cd 100644
> --- a/odb/transaction.h
> +++ b/odb/transaction.h
> @@ -125,7 +125,7 @@ static inline void odb_transaction_begin_or_die(struct object_database *odb,
>  						enum odb_transaction_flags flags)
>  {
>  	if (odb_transaction_begin(odb, out, flags))
> -		die(_("failed to start ODB transaction"));
> +		die(_("failed to start object transaction"));
>  }
>  
>  /*
> @@ -146,9 +146,9 @@ int odb_transaction_finalize(struct odb_transaction *transaction);
>  static inline void odb_transaction_commit_and_finalize_or_die(struct odb_transaction *transaction)
>  {
>  	if (odb_transaction_commit(transaction))
> -		die(_("failed to commit ODB transaction"));
> +		die(_("failed to commit object transaction"));
>  	if (odb_transaction_finalize(transaction))
> -		die(_("failed to finalize ODB transaction"));
> +		die(_("failed to finalize object transaction"));
>  }
Thanks for including this, the changes look obviously good to me.
Patrick
Previous: Justin ToblerNext: Justin Tobler
Message 26 of 29 in “object-file: eagerly create ODB transaction temporary directory”
  1. 0/4 object-file: eagerly create ODB transaction temporary directoryJustin Tobler, Nov 10, 2026
  2. 1/4 object-file: rename default transaction prefixJustin Tobler, Nov 10, 2026
  3. Patrick SteinhardtNov 11, 2026
  4. Karthik NayakNov 11, 2026
  5. 2/4 object-file: only flush batched fsync writes when enabledJustin Tobler, Nov 10, 2026
  6. Patrick SteinhardtNov 11, 2026
  7. Justin ToblerNov 17, 2026
  8. Karthik NayakNov 11, 2026
  9. Justin ToblerNov 17, 2026
  10. 3/4 tmp-objdir: preserve errno when directory creation failsJustin Tobler, Nov 10, 2026
  11. Patrick SteinhardtNov 11, 2026
  12. Karthik NayakNov 11, 2026
  13. Justin ToblerNov 17, 2026
  14. 4/4 object-file: create ODB transaction temporary directory eagerlyJustin Tobler, Nov 10, 2026
  15. Patrick SteinhardtNov 11, 2026
  16. Justin ToblerNov 17, 2026
  17. Karthik NayakNov 11, 2026
  18. Justin ToblerNov 17, 2026
  19. Karthik NayakNov 11, 2026
  20. 0/6 object-file: eagerly create ODB transaction temporary directoryJustin Tobler, Nov 19, 2026
  21. 1/6 object-file: rename default transaction prefixJustin Tobler, Nov 19, 2026
  22. 2/6 object-file: only flush batched fsync writes when enabledJustin Tobler, Nov 19, 2026
  23. 3/6 tmp-objdir: inline `setup_tmp_objdir()`Justin Tobler, Nov 19, 2026
  24. 4/6 tmp-objdir: preserve errno when directory creation failsJustin Tobler, Nov 19, 2026
  25. 5/6 odb/transaction: avoid "ODB" in error messagesJustin Tobler, Nov 19, 2026
  26. Patrick SteinhardtNov 19, 2026
  27. 6/6 object-file: create ODB transaction temporary directory eagerlyJustin Tobler, Nov 19, 2026
  28. Patrick SteinhardtNov 19, 2026
  29. Junio C HamanoNov 19, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.