git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 4/4] object-file: create ODB transaction temporary directory eagerly

From
Justin Tobler <jltobler@gmail.com>
Date
Nov 17, 2026, 23:48 UTC
Message-ID
<avznZz5351gjqPVQ@denethor>
In-Reply-To
<avRqiH9eIpJUGKMo@pks.im>
On 26/11/11 02:15PM, Patrick Steinhardt wrote:
Show 8 quoted lines
> On Mon, Nov 09, 2026 at 06:22:51PM -0600, Justin Tobler wrote:
> > +	prefix = flags & ODB_TRANSACTION_RECEIVE ? "incoming" : "transaction";
> 
> Makes me wonder whether it's important to keep the "incoming" prefix
> here or whether there is an argument to be made that it should simply be
> called "transaction", as well.
> 
> That may be out of scope for this series though.

Ya, this is something I would also like to change, but I decided to leave it for a future series. :)

[snip]
Show 16 quoted lines
> > diff --git a/t/t0004-unwritable.sh b/t/t0004-unwritable.sh
> > index 3bdafbae0f..7292672a66 100755
> > --- a/t/t0004-unwritable.sh
> > +++ b/t/t0004-unwritable.sh
> > @@ -24,8 +24,8 @@ test_expect_success POSIXPERM,SANITY 'write-tree should notice unwritable reposi
> >  test_lazy_prereq WRITE_TREE_OUT 'test -e "$TRASH_DIRECTORY"/out.write-tree'
> >  test_expect_success WRITE_TREE_OUT 'write-tree output on unwritable repository' '
> >  	cat >expect <<-\EOF &&
> > -	error: insufficient permission for adding an object to repository database .git/objects
> > -	fatal: git-write-tree: error building trees
> > +	error: unable to create temporary object directory in .git/objects: Permission denied
> > +	fatal: failed to start ODB transaction
> 
> Not a new issue, but this second error message is awful. An average user
> won't have any idea what an "ODB" even is. s/ODB/object/ would make a
> lot more sense.

I agree. I'll add another small patch in the next version that changes this.

-Justin
Previous: Patrick SteinhardtNext: Karthik Nayak
Message 16 of 19 in “object-file: eagerly create ODB transaction temporary directory”
  1. 0/4 object-file: eagerly create ODB transaction temporary directoryJustin Tobler, Nov 10, 2026
  2. 1/4 object-file: rename default transaction prefixJustin Tobler, Nov 10, 2026
  3. Patrick SteinhardtNov 11, 2026
  4. Karthik NayakNov 11, 2026
  5. 2/4 object-file: only flush batched fsync writes when enabledJustin Tobler, Nov 10, 2026
  6. Patrick SteinhardtNov 11, 2026
  7. Justin ToblerNov 17, 2026
  8. Karthik NayakNov 11, 2026
  9. Justin ToblerNov 17, 2026
  10. 3/4 tmp-objdir: preserve errno when directory creation failsJustin Tobler, Nov 10, 2026
  11. Patrick SteinhardtNov 11, 2026
  12. Karthik NayakNov 11, 2026
  13. Justin ToblerNov 17, 2026
  14. 4/4 object-file: create ODB transaction temporary directory eagerlyJustin Tobler, Nov 10, 2026
  15. Patrick SteinhardtNov 11, 2026
  16. Justin ToblerNov 17, 2026
  17. Karthik NayakNov 11, 2026
  18. Justin ToblerNov 17, 2026
  19. Karthik NayakNov 11, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.