Re: [PATCH 1/4] object-file: rename default transaction prefix
- From
Karthik Nayak <karthik.188@gmail.com>
- Date
- Nov 11, 2026, 14:36 UTC
- Message-ID
- <CAOLa=ZRpoB5+woCf=D6PAWkQZ+jDkoDgkpffh=AYwCa8BefQyw@mail.gmail.com>
- In-Reply-To
- <20261110002251.2007617-2-jltobler@gmail.com>
Justin Tobler <jltobler@gmail.com> writes:
Show 29 quoted lines
> By default, the temporary directory created for a "files" ODB > transaction has its name prefixed with "bulk-fsync". This name dates > back to c0f4752ed2 (core.fsyncmethod: batched disk flushes for > loose-objects, 2022-04-04), where the temporary object directory only > served to batch fsyncs of loose objects. > > ODB transactions have since grown into a more general interface for > writing objects though, and the temporary object directory is not > inherently tied to how objects are synced. In a subsequent commit, the > temporary object directory is created for every transaction regardless > of the configured fsync method, which would make the name misleading. > > Rename the default prefix to "transaction" accordingly. > > Signed-off-by: Justin Tobler <jltobler@gmail.com> > --- > object-file.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/object-file.c b/object-file.c > index 132aaab6f8..201d9d6490 100644 > --- a/object-file.c > +++ b/object-file.c > @@ -1566,7 +1566,7 @@ int odb_transaction_files_begin(struct odb_source *source, > transaction->flags = flags; > strvec_init(&transaction->pack_names); > > - transaction->prefix = "bulk-fsync"; > + transaction->prefix = "transaction";
Okay so the prefix is fed to `tmp_objdir_create()`, which will then name it 'tmp_objdir-transaction-XXXXXX'. So this makes sense as we use ODB transactions in a general sense.
Show 5 quoted lines
> if (flags & ODB_TRANSACTION_RECEIVE) {
> /*
> * ODB transactions for git-receive-pack(1) eagerly create a
> --
> 2.56.0.173.gf57c9a7388