Re: [PATCH 2/4] object-file: only flush batched fsync writes when enabled
- From
Justin Tobler <jltobler@gmail.com>
- Date
- Nov 17, 2026, 23:42 UTC
- Message-ID
- <avzlrYKsGIbyMz8r@denethor>
- In-Reply-To
- <CAOLa=ZRp=JeAGhN3m6-RCos3F82__6Wzt2UsKvUjqHSHUg6o_Q@mail.gmail.com>
On 26/11/11 06:48AM, Karthik Nayak wrote:
Show 11 quoted lines
> Justin Tobler <jltobler@gmail.com> writes: > > > When committing an ODB transaction for the "files" backend, a full > > hardware flush is issued against a temporary file before the staged > > objects are migrated into the main object database. This flush acts as a > > barrier for objects that have been written with batched fsync, where > > `odb_transaction_files_fsync()` only issues a writeout request for each > > object instead of fully syncing it. > > > > Does `fsync(fd)` even guarantee syncing of previous writes?
I believe the answer here is platform specific. This feature oringally comes from c0f4752ed2 (core.fsyncmethod: batched disk flushes for loose-objects, 2022-04-04) which has a pretty good explaination. :)
Show 39 quoted lines
> > The flush is issued whenever the transaction has a temporary object
> > directory though, regardless of whether batched fsync is actually
> > enabled. For transactions configured for git-receive-pack(1), the
> > temporary object directory is always created, so the flush is also
> > performed when objects are synced individually or not synced at all. In
> > those cases there are no pending writeout requests and the flush is
> > unnecessary. Only issue the flush when batched fsync is enabled
> > accordingly.
> >
> > Signed-off-by: Justin Tobler <jltobler@gmail.com>
> > ---
> > object-file.c | 43 +++++++++++++++++++++++++------------------
> > 1 file changed, 25 insertions(+), 18 deletions(-)
> >
> > diff --git a/object-file.c b/object-file.c
> > index 201d9d6490..da189111bd 100644
> > --- a/object-file.c
> > +++ b/object-file.c
> > @@ -1330,6 +1330,29 @@ static int write_pack_lockfiles(struct odb_transaction_files *transaction)
> > return ret;
> > }
> >
> > +static void flush_batched_fsync(struct repository *repo)
> > +{
> > + struct strbuf temp_path = STRBUF_INIT;
> > + struct tempfile *temp;
> > +
> > + /*
> > + * Issue a full hardware flush against a temporary file to ensure
> > + * that all objects are durable before any renames occur. The code in
> > + * odb_transaction_files_fsync has already issued a writeout
> > + * request, but it has not flushed any writeback cache in the storage
> > + * hardware or any filesystem logs. This fsync call acts as a barrier
> > + * to ensure that the data in each new object file is durable before
> > + * the final name is visible.
> > + */
>
> Nit: This could become a function comment, since it now describes the
> function well.Will do in the next version.
-Justin