From: Patrick Steinhardt Date: Thu, 19 Nov 2026 12:15:20 GMT Subject: Re: [PATCH v2 5/6] odb/transaction: avoid "ODB" in error messages Message-ID: In-Reply-To: <20261119002043.2108654-6-jltobler@gmail.com> On Wed, Nov 18, 2026 at 06:20:42PM -0600, Justin Tobler wrote: > diff --git a/odb/transaction.h b/odb/transaction.h > index 2a40c85bc8..f6c4b523cd 100644 > --- a/odb/transaction.h > +++ b/odb/transaction.h > @@ -125,7 +125,7 @@ static inline void odb_transaction_begin_or_die(struct object_database *odb, > enum odb_transaction_flags flags) > { > if (odb_transaction_begin(odb, out, flags)) > - die(_("failed to start ODB transaction")); > + die(_("failed to start object transaction")); > } > > /* > @@ -146,9 +146,9 @@ int odb_transaction_finalize(struct odb_transaction *transaction); > static inline void odb_transaction_commit_and_finalize_or_die(struct odb_transaction *transaction) > { > if (odb_transaction_commit(transaction)) > - die(_("failed to commit ODB transaction")); > + die(_("failed to commit object transaction")); > if (odb_transaction_finalize(transaction)) > - die(_("failed to finalize ODB transaction")); > + die(_("failed to finalize object transaction")); > } Thanks for including this, the changes look obviously good to me. Patrick