Re: [PATCH 1/4] object-file: rename default transaction prefix
- From
Patrick Steinhardt <ps@pks.im>
- Date
- Nov 11, 2026, 13:15 UTC
- Message-ID
- <avRqjlLbMOfFRQse@pks.im>
- In-Reply-To
- <20261110002251.2007617-2-jltobler@gmail.com>
On Mon, Nov 09, 2026 at 06:22:48PM -0600, Justin Tobler wrote:
Show 9 quoted lines
> By default, the temporary directory created for a "files" ODB > transaction has its name prefixed with "bulk-fsync". This name dates > back to c0f4752ed2 (core.fsyncmethod: batched disk flushes for > loose-objects, 2022-04-04), where the temporary object directory only > served to batch fsyncs of loose objects. > > ODB transactions have since grown into a more general interface for > writing objects though, and the temporary object directory is not > inherently tied to how objects are synced.
Right. We don't really use it for a lot of cases yet, but we anticipate that we'll start using it more often now that it becomes more generally useful.
Show 5 quoted lines
> In a subsequent commit, the > temporary object directory is created for every transaction regardless > of the configured fsync method, which would make the name misleading. > > Rename the default prefix to "transaction" accordingly.
We could of course change the logic so that we make the prefix dependent on the actual caller. But I really doubt that this would be sensible, so I'm very much aligned with naming those directories more generically.
Patrick