Re: [PATCH 05/10] http-push: Avoid calling setup_git_directory() twice

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Mar 11, 2008, 15:08 UTC
Message-ID: <alpine.LSU.1.00.0803111604240.3873@racer.site>
In-Reply-To: <fcaeb9bf0803110754v7191d8fckbde0e1313e6a69ec@mail.gmail.com>

Hi,

On Tue, 11 Mar 2008, Nguyen Thai Ngoc Duy wrote:

Show 12 quoted lines

> On Tue, Mar 11, 2008 at 8:28 PM, Johannes Schindelin
> <Johannes.Schindelin@gmx.de> wrote:
>
> >  On Sun, 2 Mar 2008, Nguy�n Th�i Ng�c Duy wrote:
> >
> >  > Signed-off-by: Nguy�n Th�i Ng�c Duy <pclouds@gmail.com>
> >
> >  This fix is completely independent of the rest of your series.
> 
> Not really. It would have no impact (good or bad) if sent separately. 
> But it is required by the series (otherwise it would die() under certain 
> condition because prefix cannot be recomputed properly).

Well, it _is_ independent. Either you say "we want to have this as an example where you can call setup_git_directory() twice" (which I would not find all that bad), or you say "this was calling setup_git_directory() twice, fix that".

In any case, it should be separate from this series.

Back to the subject of this series: as I stated already, I do not like the separation of work-tree and git directory, and I especially do not like how much you had to work outside setup.c. I think changing the semantics for all callers was not necessary, and in fact, not desirable.

Ciao, Dscho