From: Johannes Schindelin Date: Tue, 11 Mar 2008 15:08:07 GMT Subject: Re: [PATCH 05/10] http-push: Avoid calling setup_git_directory() twice Message-ID: In-Reply-To: Hi, On Tue, 11 Mar 2008, Nguyen Thai Ngoc Duy wrote: > On Tue, Mar 11, 2008 at 8:28 PM, Johannes Schindelin > wrote: > > > On Sun, 2 Mar 2008, Nguy�n Th�i Ng�c Duy wrote: > > > > > Signed-off-by: Nguy�n Th�i Ng�c Duy > > > > This fix is completely independent of the rest of your series. > > Not really. It would have no impact (good or bad) if sent separately. > But it is required by the series (otherwise it would die() under certain > condition because prefix cannot be recomputed properly). Well, it _is_ independent. Either you say "we want to have this as an example where you can call setup_git_directory() twice" (which I would not find all that bad), or you say "this was calling setup_git_directory() twice, fix that". In any case, it should be separate from this series. Back to the subject of this series: as I stated already, I do not like the separation of work-tree and git directory, and I especially do not like how much you had to work outside setup.c. I think changing the semantics for all callers was not necessary, and in fact, not desirable. Ciao, Dscho