git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 04/10] Make setup_work_tree() return new prefix

From
Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Date
Mar 11, 2008, 15:18 UTC
Message-ID
<fcaeb9bf0803110818t6c009b29k5afb4f8b3833d475@mail.gmail.com>
In-Reply-To
<alpine.LSU.1.00.0803111426521.3873@racer.site>

On Tue, Mar 11, 2008 at 8:27 PM, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:

Show 11 quoted lines
> Hi,
>
>
>  On Sun, 2 Mar 2008, Nguyễn Thái Ngọc Duy wrote:
>
>  > worktree setup inside setup_git_directory*() is not perfect. It does not
>  > take core.worktree into account. So when you do setup_work_tree(), the
>  > real work tree may be not the one setup_git_directory*() gives you. You
>  > need a new prefix in that case.
>
>  Probably the real fix would be to setup_git_directory(), no?

setup_work_tree() does the job fine. Why duplicate the code one more? In the old days, setup_git_directory() was just a simple wrapper around setup_git_dir_gently(). I wanted to move it back to those days. And setup_git_directory() is fixed in "Completely move out worktree setup from setup_git_directory_gently()" so setup_git_directory() does contain the real fix in the end.

>  Ciao,
>  Dscho
-- 
Duy
Previous: Johannes SchindelinNext: Nguyễn Thái Ngọc Duy
Message 15 of 32 in “"git read-tree -m" and the like require worktree”
  1. 01/10 "git read-tree -m" and the like require worktreeNguyễn Thái Ngọc Duy, Mar 2, 2008
  2. Johannes SchindelinMar 11, 2008
  3. Nguyen Thai Ngoc DuyMar 11, 2008
  4. Johannes SchindelinMar 11, 2008
  5. Nguyen Thai Ngoc DuyMar 11, 2008
  6. 02/10 Make sure setup_git_directory is called before accessing repositoryNguyễn Thái Ngọc Duy, Mar 2, 2008
  7. 03/10 Make get_git_dir() and 'git rev-parse --git-dir' absolute pathNguyễn Thái Ngọc Duy, Mar 2, 2008
  8. Johannes SchindelinMar 11, 2008
  9. Nguyen Thai Ngoc DuyMar 11, 2008
  10. Johannes SchindelinMar 11, 2008
  11. Nguyen Thai Ngoc DuyMar 11, 2008
  12. Johannes SchindelinMar 11, 2008
  13. 04/10 Make setup_work_tree() return new prefixNguyễn Thái Ngọc Duy, Mar 2, 2008
  14. Johannes SchindelinMar 11, 2008
  15. Nguyen Thai Ngoc DuyMar 11, 2008
  16. 05/10 http-push: Avoid calling setup_git_directory() twiceNguyễn Thái Ngọc Duy, Mar 2, 2008
  17. Johannes SchindelinMar 11, 2008
  18. Nguyen Thai Ngoc DuyMar 11, 2008
  19. Johannes SchindelinMar 11, 2008
  20. Nguyen Thai Ngoc DuyMar 11, 2008
  21. 06/10 Completely move out worktree setup from setup_git_directory_gently()Nguyễn Thái Ngọc Duy, Mar 2, 2008
  22. Johannes SchindelinMar 11, 2008
  23. Nguyen Thai Ngoc DuyMar 11, 2008
  24. Johannes SchindelinMar 11, 2008
  25. 07/10 builtin-archive: mark unused prefix "unused_prefix"Nguyễn Thái Ngọc Duy, Mar 2, 2008
  26. Johannes SchindelinMar 11, 2008
  27. Nguyen Thai Ngoc DuyMar 11, 2008
  28. Jay SoffianMar 11, 2008
  29. Nguyen Thai Ngoc DuyMar 11, 2008
  30. 08/10 Make setup_git_directory() auto-setup worktree if foundNguyễn Thái Ngọc Duy, Mar 2, 2008
  31. 09/10 Documentation: update api-builtin and api-setupNguyễn Thái Ngọc Duy, Mar 2, 2008
  32. 10/10 Additional tests to capture worktree special casesNguyễn Thái Ngọc Duy, Mar 2, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.