git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 05/10] http-push: Avoid calling setup_git_directory() twice

From
Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Date
Mar 11, 2008, 16:12 UTC
Message-ID
<fcaeb9bf0803110912n480d8f42kde0956609519de83@mail.gmail.com>
In-Reply-To
<alpine.LSU.1.00.0803111604240.3873@racer.site>

On Tue, Mar 11, 2008 at 10:08 PM, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:

Show 25 quoted lines
> Hi,
>
>
>  On Tue, 11 Mar 2008, Nguyen Thai Ngoc Duy wrote:
>
>  > On Tue, Mar 11, 2008 at 8:28 PM, Johannes Schindelin
>  > <Johannes.Schindelin@gmx.de> wrote:
>  >
>  > >  On Sun, 2 Mar 2008, Nguy­n Thái Ng÷c Duy wrote:
>  > >
>  > >  > Signed-off-by: Nguy­n Thái Ng÷c Duy <pclouds@gmail.com>
>
> > >
>  > >  This fix is completely independent of the rest of your series.
>  >
>  > Not really. It would have no impact (good or bad) if sent separately.
>  > But it is required by the series (otherwise it would die() under certain
>  > condition because prefix cannot be recomputed properly).
>
>  Well, it _is_ independent.  Either you say "we want to have this as an
>  example where you can call setup_git_directory() twice" (which I would not
>  find all that bad), or you say "this was calling setup_git_directory()
>  twice, fix that".
>
>  In any case, it should be separate from this series.

My point stands still. It is merely cleanup without harm or goodness if seperated from the series. This patch does not fix the real problem.

>  Back to the subject of this series: as I stated already, I do not like the
>  separation of work-tree and git directory, and I especially do not like
>  how much you had to work outside setup.c.  I think changing the semantics
>  for all callers was not necessary, and in fact, not desirable.

For one, setup_work_tree() prototype change is necessary to deal with (gitdir autodetection + core.worktree + setup_work_tree()).

For setup_*gently() changes, I think I can make setup_git_directory_gently() retain its current semantics by removing 06/10 and 07/10. But I do think it's nice to have setup_*_gently() does things gently _and_ easily-predictable (current _gently() setups worktree under certain conditions and not otherwise, which I consider uneasily-predictable). Patch 06 and 07 are mainly cleanup as a result from _gently() changes. Are those most intrusive to you?

>  Ciao,
>  Dscho
>
-- 
Duy
Previous: Johannes SchindelinNext: Nguyễn Thái Ngọc Duy
Message 20 of 32 in “"git read-tree -m" and the like require worktree”
  1. 01/10 "git read-tree -m" and the like require worktreeNguyễn Thái Ngọc Duy, Mar 2, 2008
  2. Johannes SchindelinMar 11, 2008
  3. Nguyen Thai Ngoc DuyMar 11, 2008
  4. Johannes SchindelinMar 11, 2008
  5. Nguyen Thai Ngoc DuyMar 11, 2008
  6. 02/10 Make sure setup_git_directory is called before accessing repositoryNguyễn Thái Ngọc Duy, Mar 2, 2008
  7. 03/10 Make get_git_dir() and 'git rev-parse --git-dir' absolute pathNguyễn Thái Ngọc Duy, Mar 2, 2008
  8. Johannes SchindelinMar 11, 2008
  9. Nguyen Thai Ngoc DuyMar 11, 2008
  10. Johannes SchindelinMar 11, 2008
  11. Nguyen Thai Ngoc DuyMar 11, 2008
  12. Johannes SchindelinMar 11, 2008
  13. 04/10 Make setup_work_tree() return new prefixNguyễn Thái Ngọc Duy, Mar 2, 2008
  14. Johannes SchindelinMar 11, 2008
  15. Nguyen Thai Ngoc DuyMar 11, 2008
  16. 05/10 http-push: Avoid calling setup_git_directory() twiceNguyễn Thái Ngọc Duy, Mar 2, 2008
  17. Johannes SchindelinMar 11, 2008
  18. Nguyen Thai Ngoc DuyMar 11, 2008
  19. Johannes SchindelinMar 11, 2008
  20. Nguyen Thai Ngoc DuyMar 11, 2008
  21. 06/10 Completely move out worktree setup from setup_git_directory_gently()Nguyễn Thái Ngọc Duy, Mar 2, 2008
  22. Johannes SchindelinMar 11, 2008
  23. Nguyen Thai Ngoc DuyMar 11, 2008
  24. Johannes SchindelinMar 11, 2008
  25. 07/10 builtin-archive: mark unused prefix "unused_prefix"Nguyễn Thái Ngọc Duy, Mar 2, 2008
  26. Johannes SchindelinMar 11, 2008
  27. Nguyen Thai Ngoc DuyMar 11, 2008
  28. Jay SoffianMar 11, 2008
  29. Nguyen Thai Ngoc DuyMar 11, 2008
  30. 08/10 Make setup_git_directory() auto-setup worktree if foundNguyễn Thái Ngọc Duy, Mar 2, 2008
  31. 09/10 Documentation: update api-builtin and api-setupNguyễn Thái Ngọc Duy, Mar 2, 2008
  32. 10/10 Additional tests to capture worktree special casesNguyễn Thái Ngọc Duy, Mar 2, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.