Re: [PATCH 03/10] Make get_git_dir() and 'git rev-parse --git-dir' absolute path

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Mar 11, 2008, 16:20 UTC
Message-ID: <alpine.LSU.1.00.0803111716500.3873@racer.site>
In-Reply-To: <fcaeb9bf0803110839m582bed5cr5b3e198712e0fe8e@mail.gmail.com>

Hi,

On Tue, 11 Mar 2008, Nguyen Thai Ngoc Duy wrote:

Show 8 quoted lines

> On Tue, Mar 11, 2008 at 10:18 PM, Johannes Schindelin
> <Johannes.Schindelin@gmx.de> wrote:
> >  Besides, I remember that Junio specifically requested that I would 
> >  _not_ do something like that (this was for --show-cdup, but I think 
> >  it really applies here, too).
> 
> I might have lost track. Could you provide me the link for reference? 
> Thanks.

http://article.gmane.org/gmane.comp.version-control.git/53993/match=show+cdup

This is how you can find it yourself next time (and how I found it):

Go to gmane, search for "show-cdup", then select Junio as writer. It is already the second hit, which was obvious by the email's title.

Show 9 quoted lines

> >  I do not see the problem.  And therefore I do not see that this patch 
> >  solves anything.
> 
> It can simplify things (in other patches, such as builtin-config.c 
> changes). Though without it things just run fine (with a little more 
> complication in prefix handling). Recent mails about git-am running in 
> subdirectory (Message-ID: 
> 20080301062255.GA27538@coredump.intra.peff.net) made me think there was 
> room for this.

Okay, I see that you want to simplify things. However, I am not at all convinced that your patch series does that.

However, instead of continuing this thread, I will try to find some time later this week to look into simplifying the work-tree logic again.

If I find things, I will discuss them on the list.

Ciao, Dscho