Re: [PATCH 08/13] transport-helper: export should disconnect too

From: Daniel Barkalow <barkalow@iabervon.org>
Date: Aug 29, 2010, 19:32 UTC
Message-ID: <alpine.LNX.2.00.1008291529510.14365@iabervon.org>
In-Reply-To: <1283053540-27042-9-git-send-email-srabbelier@gmail.com>

On Sat, 28 Aug 2010, Sverre Rabbelier wrote:

Show 8 quoted lines

> Now that the remote helper protocol uses the new done command in its
> fast-import streams, export no longer needs to be the last command in
> the stream.
> ---
> 
>   The fact that we had this before shows how messed up the protocol
>   was earlier. Basically, any 'import' or 'export' command meant
>   "you're done talking to the helper now".

Yup; this is a big improvement, and I'dhave done it this way in the first place, had I realized how easy it would be to get fast-import to have a "done" command. Your subject is backwards, I think, though; export won't require a disconnect.

	-Daniel
*This .sig left intentionally blank*