Re: [PATCH 03/13] transport-helper: factor out push_update_refs_status

From: Sverre Rabbelier <srabbelier@gmail.com>
Date: Aug 29, 2010, 21:45 UTC
Message-ID: <AANLkTikP_Mm4C2C_TC57Adi9egPMdv83htc1J8ZJ4mN-@mail.gmail.com>
In-Reply-To: <20100829213618.GD1890@burratino>

Heya,

On Sun, Aug 29, 2010 at 16:36, Jonathan Nieder <jrnieder@gmail.com> wrote:

Show 12 quoted lines

> Hmm, I am not too happy with the long loop without explicit condition.
> Maybe it would make sense to split out the loop body as its own function?
> Something like
>
>        struct ref *ref = remote_refs;
>        for (;;) {
>                recvline(data, &buf);
>                if (!buf.len)
>                        break;
>
>                push_update_ref_status(&buf, &ref, remote_refs);
>        }

Ok, will fix.

Show 5 quoted lines

>>       strbuf_release(&buf);
>> -     return 0;
>> +     return;
>
> Not necessary, I think.

Removed the return.

> Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
>
> Thanks for a pleasant read.

Thanks for reading :).

-- 
Cheers,

Sverre Rabbelier