Re: [PATCH 10/13] transport-helper: implement marks location as capability

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Aug 30, 2010, 01:31 UTC
Message-ID: <20100830013156.GD2305@burratino>
In-Reply-To: <1283053540-27042-11-git-send-email-srabbelier@gmail.com>

Sverre Rabbelier wrote:

Show 10 quoted lines

> --- a/git-remote-testgit.py
> +++ b/git-remote-testgit.py
> @@ -71,8 +71,24 @@ def do_capabilities(repo, args):
>      print "import"
>      print "export"
>      print "gitdir"
> +
> +    sys.stdout.flush()
> +    if not read_one_line(repo):
> +        die("Expected gitdir, got empty line")

This seems fragile to me: shouldn't the remote helper check somehow that the line it read was actually a gitdir line?

No other complaint on my part. Requiring a flush seems entirely appropriate to me, and if someone comes up with something nicer than the "capabilities" sequence for requesting information, it would not be the end of the world to have two ways to discover the .git dir.