Re: [PATCH 01/13] fast-import: add the 'done' command

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Aug 30, 2010, 02:02 UTC
Message-ID: <20100830020236.GH2305@burratino>
In-Reply-To: <AANLkTik3H6hVgViAX5ur9Tq4tFQ9mJEPuTmAwcrLStvU@mail.gmail.com>

Sverre Rabbelier wrote:

> On Sun, Aug 29, 2010 at 17:32, Jonathan Nieder <jrnieder@gmail.com> wrote:

Show 10 quoted lines

>> where an error might go undiagnosed (and any error message drowned out
>> by the summary fast-import writes at the end).
>>
>> Will think more.
>
> As far as I'm concerned that should be the responsibility of the
> importer. If there is an error it should make sure not to drown the
> error message with it's summary. I think it does a pretty good job at
> that already though, doesn't it? It even saves a log file to try and
> help you diagnose what went wrong.

I was thinking specifically of the case where one is unlucky enough for the stream to end at a valid, early spot.

The way all importers seem to end up is to call "git fast-import" as a child process (rather than advertising an interface like

	svnrdump dump <URI> | svn-fe | git fast-import

) so maybe this is not such a big deal.