Re: [PATCH 07/13] transport-helper: change import semantics

From: Daniel Barkalow <barkalow@iabervon.org>
Date: Aug 29, 2010, 19:29 UTC
Message-ID: <alpine.LNX.2.00.1008291521350.14365@iabervon.org>
In-Reply-To: <1283053540-27042-8-git-send-email-srabbelier@gmail.com>

On Sat, 28 Aug 2010, Sverre Rabbelier wrote:

Show 6 quoted lines

> Currently the helper must somehow guess how many import statements to
> read before it starts outputting its fast-export stream. This is
> because the remote helper infrastructure runs fast-import only once,
> so the helper is forced to output one stream for all import commands
> it will receive. The only reason this worked in the past was because
> only one ref was imported at a time.

I think your reasons for this change could be worked around, but the protocol is cleaner with your change, which is justification enough, given that it shouldn't be too big a deal to change. This also lets the helper consider all of the refs it is expected to update before producing the stream, which may simplify the stream (particularly if the history has merges involving branches that may or may not be imported are aren't listed first).

Show 8 quoted lines

> Change the semantics of the import statement such that it matches
> that of the list statement. That is, 'import\n' is followed by a list
> of refs that should be exported, followed by '\n'.
> ---
> 
>   This changes the protcol a bit, but I don't think we have many
>   users of the 'import' command yet, and if we do I would assume
>   they're paying attention to development in the remote helper space.

I don't think "import" has gotten to the point where people could really use it in helpers not packaged with git, anyway, so I agree.

	-Daniel
*This .sig left intentionally blank*