Re: Bizarre missing changes (git bug?)
- From
Linus Torvalds <torvalds@linux-foundation.org>
- Date
- Jul 31, 2008, 00:30 UTC
- Message-ID
- <alpine.LFD.1.10.0807301720170.3277@nehalem.linux-foundation.org>
- In-Reply-To
- <7vej5b3ozz.fsf@gitster.siamese.dyndns.org>
On Wed, 30 Jul 2008, Junio C Hamano wrote:
> > I am not Roman, but so I do not know if I did what Roman wanted to, but > here is a quick hack. "gitk --post-simplify -- kernel/printk.c" is > slightly more readable than --full-history with this patch.
.. and if by "slightly", you mean "a lot", then yes.
Patch looks fine to me. I didn't look at the code logic very closely, but I suspect that it's actually hard to get the right answer with broken code, and the logic doesn't look broken. So Ack.
The filter-branch thing should probably be taught about this at least as an option. I think it was Johannes Sixt that worried about that one. Added to cc.
Linus