Re: [PATCH v2 11/17] am: counteract gender bias

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jul 7, 2016, 11:30 UTC
Message-ID: <alpine.DEB.2.20.1607071323440.6426@virtualbox>
In-Reply-To: <xmqq1t36sbqt.fsf@gitster.mtv.corp.google.com>

Hi Junio,

On Wed, 6 Jul 2016, Junio C Hamano wrote:

Show 16 quoted lines

> Johannes Schindelin <johannes.schindelin@gmx.de> writes:
> 
> > Since d1c5f2a (Add git-am, applymbox replacement., 2005-10-07), i.e. for
> > almost 11 years already,...
> > ...Let's start changing that by using the variable name "her_tree" for an
> > equal number of years out of fairness, and change to the gender neutral
> > "their_tree" after that.
> 
> I doubt this kind fo distraction is desirable in the middle of a
> seriously heavy series like this one.  As a standalone clean-up to
> turn these directly to "their" that everybody would agree on and can
> be merged down quickly to 'master' that does not have to keep the
> body of the main topic waiting for the dust to settle might be a
> better approach.
> 
> Unless you are trying to discourage the reviewers, that is ;-).

Funny. In other comments, I am asked to patch things that are truly unrelated to the patch series' intent, and here I am asked to refrain from cleaning up the code before I touch it.

I am really curious, though. Has it not been our practice to encourage preparatory patches like white-space or const fixes as part of patch series that touch a certain part of the code that needed fixing? I deem this here patch to be much, much more important than a mere white-space or const fix.

Since you asked so nicely, I will break out this patch from the patch series, of course, but please note that it will now look as if I willfully snuck in an unrelated change in the next patch, just because I was not allowed to prepare the code properly.

Ciao, Dscho