Re: [PATCH v2 02/17] Report bugs consistently

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jul 5, 2016, 13:38 UTC
Message-ID: <alpine.DEB.2.20.1607051535550.8378@virtualbox>
In-Reply-To: <577BB09E.5070801@gmail.com>

Hi Kuba,

On Tue, 5 Jul 2016, Jakub Narębski wrote:

Show 19 quoted lines

> W dniu 2016-07-05 o 13:23, Johannes Schindelin pisze:
> > diff --git a/builtin/ls-files.c b/builtin/ls-files.c
> > index f02e3d2..00ea91a 100644
> > --- a/builtin/ls-files.c
> > +++ b/builtin/ls-files.c
> > @@ -118,7 +118,8 @@ static void show_killed_files(struct dir_struct *dir)
> >  				 */
> >  				pos = cache_name_pos(ent->name, ent->len);
> >  				if (0 <= pos)
> > -					die("bug in show-killed-files");
> > +					die("BUG: killed-file %.*s not found",
> > +						ent->len, ent->name);
> >  				pos = -pos - 1;
> >  				while (pos < active_nr &&
> >  				       ce_stage(active_cache[pos]))
> 
> This has an additional improvement (not mentioned in the commit
> message, but probably not worth it) in that it shows which file
> was not found, not only that there was some bug, isn't it?

Sure, it improves that report. In the unlikely event that a bug is encountered :-)

Is it really worth mentioning in the commit message?

Looking at it again, however, I think there is a bug in my patch. It says that the file was not found, but pos was non-negative, so it was found unexpectedly. So I think I should strike the "not" part. Would you concur?

Ciao, Dscho