Re: [PATCH 1/9] Report bugs consistently
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Jun 30, 2016, 08:42 UTC
- Message-ID
- <alpine.DEB.2.20.1606301041380.12947@virtualbox>
- In-Reply-To
- <xmqqfurv3ejz.fsf@gitster.mtv.corp.google.com>
Hi Junio,
On Wed, 29 Jun 2016, Junio C Hamano wrote:
Show 13 quoted lines
> Johannes Schindelin <johannes.schindelin@gmx.de> writes:
>
> > The vast majority of error messages in Git's source code which report a
> > bug use the convention to prefix the message with "BUG:".
>
> Good thing to do.
>
> But if we were to review and apply a 200+ line patch, I wonder if we
> want to go one step further to allow us to write
>
> BUG("killed-file %s not found", name);
>
> instead.If the idea is to make it easier to find, I would wager a guess that 'die("BUG:' would be just as good a search term. Even better, I think, because 'BUG' would also match comments.
Ciao, Dscho